Some bad fonctionnement correction

herudo's Avatar

herudo

02 Dec, 2010 09:50 AM

Hello, i do some modification in your plugin code because I have detected some bad fonctionnement.

For example when you delete the first item previously selected, you use a bad regex in add_selected_items. It can't delete the first element so the element which is delete is already in the values_input. I use just this simply line (line 334):
values_input.val(values_input.val().replacedata[opts.selectedValuesProp]+",", ""));

The list already display the first element selected. It's allowed to select it two times and it's not very good. It's the same cause, in the search call fonction (line 275). I replace with this line:
if(str.search(query) != -1 && values_input.val().search(data[num][opts.selectedValuesProp]+",") == -1){

I hope i help you in your developpement and i have not test all the features after the modifications i did in your plugin. I hope alos you understand my very bad english :).

Godd work for this plugin and good luck for the future!

Bye, Herudo

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac